Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csprofiles: fix default decision duration, lint #2703

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 8, 2024

No description provided.

Copy link

github-actions bot commented Jan 8, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jan 8, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6960419) 55.15% compared to head (623c282) 55.17%.
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/csprofiles/csprofiles.go 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2703      +/-   ##
==========================================
+ Coverage   55.15%   55.17%   +0.02%     
==========================================
  Files         227      227              
  Lines       30388    30399      +11     
==========================================
+ Hits        16759    16772      +13     
+ Misses      12011    12009       -2     
  Partials     1618     1618              
Flag Coverage Δ
bats 36.82% <55.55%> (-0.01%) ⬇️
unit-linux 49.74% <66.66%> (+0.08%) ⬆️
unit-windows 47.96% <66.66%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review January 8, 2024 08:53
@mmetc mmetc changed the title Refact csprofiles, fix default decision duration csprofiles: fix default decision duration, lint Jan 9, 2024
@mmetc mmetc added this to the 1.5.6 milestone Jan 9, 2024
@mmetc mmetc requested a review from sabban January 12, 2024 12:56
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 733f5e1 into master Jan 12, 2024
16 checks passed
@mmetc mmetc deleted the refact-csprofiles branch January 12, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants