Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send installed appsec rules as part of the scenarios on login #2704

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented Jan 8, 2024

No description provided.

Copy link

github-actions bot commented Jan 8, 2024

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jan 8, 2024

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Jan 8, 2024

/kind fix

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (ecd1a8b) 55.14% compared to head (dc1bb28) 55.10%.

Files Patch % Lines
cmd/crowdsec/output.go 44.82% 14 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
- Coverage   55.14%   55.10%   -0.04%     
==========================================
  Files         227      227              
  Lines       30336    30356      +20     
==========================================
- Hits        16728    16727       -1     
- Misses      11990    12009      +19     
- Partials     1618     1620       +2     
Flag Coverage Δ
bats 36.73% <44.82%> (-0.03%) ⬇️
unit-linux 49.67% <ø> (-0.02%) ⬇️
unit-windows 47.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit 5d5a111 into master Jan 8, 2024
16 checks passed
@blotus blotus deleted the appsec-send-rules-on-login branch January 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants