Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiclient: handle 0-byte error response #2716

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 10, 2024

No description provided.

@mmetc mmetc added this to the 1.5.6 milestone Jan 10, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc changed the title apiclient: correctly handle 0-byte error response apiclient: handle 0-byte error response Jan 10, 2024
@mmetc mmetc added the kind/fix label Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f306d59) 55.08% compared to head (d277d7c) 54.97%.

Files Patch % Lines
pkg/apiclient/auth.go 72.72% 2 Missing and 1 partial ⚠️
pkg/apiclient/decisions_service.go 66.66% 1 Missing ⚠️
pkg/apiclient/heartbeat.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2716      +/-   ##
==========================================
- Coverage   55.08%   54.97%   -0.12%     
==========================================
  Files         227      223       -4     
  Lines       30360    29996     -364     
==========================================
- Hits        16724    16489     -235     
+ Misses      12015    11920      -95     
+ Partials     1621     1587      -34     
Flag Coverage Δ
bats 36.61% <69.23%> (-0.10%) ⬇️
unit-linux 49.67% <73.07%> (+<0.01%) ⬆️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from sabban January 10, 2024 10:22
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 437a975 into master Jan 10, 2024
16 checks passed
@mmetc mmetc deleted the checkresponse-empty-body branch January 10, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants