Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2720 #2719 #2724

Merged
merged 9 commits into from
Jan 15, 2024
Merged

fix #2720 #2719 #2724

merged 9 commits into from
Jan 15, 2024

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Jan 11, 2024

Copy link

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@buixor
Copy link
Contributor Author

buixor commented Jan 11, 2024

/kind fix
/area cscli

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (adba4e2) 55.17% compared to head (58a23f5) 55.16%.

Files Patch % Lines
pkg/dumps/parser_dump.go 74.05% 41 Missing and 14 partials ⚠️
pkg/hubtest/utils.go 0.00% 13 Missing ⚠️
pkg/dumps/bucket_dump.go 47.05% 6 Missing and 3 partials ⚠️
pkg/hubtest/parser_assert.go 0.00% 8 Missing ⚠️
cmd/crowdsec-cli/explain.go 50.00% 4 Missing and 2 partials ⚠️
pkg/hubtest/coverage.go 0.00% 3 Missing ⚠️
cmd/crowdsec-cli/hubtest.go 0.00% 2 Missing ⚠️
pkg/hubtest/scenario_assert.go 0.00% 2 Missing ⚠️
pkg/parser/runtime.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2724      +/-   ##
==========================================
- Coverage   55.17%   55.16%   -0.02%     
==========================================
  Files         227      229       +2     
  Lines       30391    30402      +11     
==========================================
+ Hits        16769    16771       +2     
- Misses      12007    12013       +6     
- Partials     1615     1618       +3     
Flag Coverage Δ
bats 36.81% <64.28%> (+0.02%) ⬆️
unit-linux 49.68% <0.00%> (-0.01%) ⬇️
unit-windows 48.53% <0.00%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor buixor marked this pull request as ready for review January 12, 2024 09:16
@buixor buixor merged commit 6ca053c into master Jan 15, 2024
16 checks passed
@buixor buixor deleted the fix_cscli_explain_order branch January 15, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cscli] Explain on whitelisted items apparently deletes all keys
3 participants