Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2733 "cscli hang forever when i try to delete a decision" #2745

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 15, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.5.6 milestone Jan 15, 2024
@mmetc mmetc added the kind/fix label Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (6acbcb0) 55.07% compared to head (520ab9f) 55.15%.
Report is 1 commits behind head on master.

❗ Current head 520ab9f differs from pull request most recent head f778337. Consider uploading reports for the commit f778337 to get more accurate results

Files Patch % Lines
pkg/apiserver/apiserver.go 0.00% 7 Missing and 1 partial ⚠️
pkg/csconfig/console.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2745      +/-   ##
==========================================
+ Coverage   55.07%   55.15%   +0.08%     
==========================================
  Files         226      230       +4     
  Lines       30145    30520     +375     
==========================================
+ Hits        16602    16833     +231     
- Misses      11963    12070     +107     
- Partials     1580     1617      +37     
Flag Coverage Δ
bats 36.81% <0.00%> (-0.10%) ⬇️
unit-linux 49.55% <0.00%> (-0.04%) ⬇️
unit-windows 48.48% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review January 16, 2024 08:08
@mmetc mmetc merged commit 24b5e8f into master Jan 16, 2024
13 checks passed
@mmetc mmetc deleted the is-papi-enabled branch January 16, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants