Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log "loading papi client" only if papi is enabled #2762

Merged
merged 1 commit into from
Jan 22, 2024
Merged

log "loading papi client" only if papi is enabled #2762

merged 1 commit into from
Jan 22, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 19, 2024

No description provided.

@mmetc mmetc marked this pull request as ready for review January 19, 2024 16:10
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added the kind/enhancement New feature or request label Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (19d36c0) 56.83% compared to head (df31f88) 56.92%.

Files Patch % Lines
pkg/apiserver/apiserver.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2762      +/-   ##
==========================================
+ Coverage   56.83%   56.92%   +0.09%     
==========================================
  Files         233      237       +4     
  Lines       30242    30615     +373     
==========================================
+ Hits        17187    17428     +241     
- Misses      11404    11502      +98     
- Partials     1651     1685      +34     
Flag Coverage Δ
bats 36.76% <0.00%> (+0.01%) ⬆️
unit-linux 52.27% <0.00%> (-0.02%) ⬇️
unit-windows 47.83% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added this to the 1.5.6 milestone Jan 19, 2024
@mmetc mmetc requested a review from blotus January 22, 2024 10:25
@mmetc mmetc merged commit dc698ec into master Jan 22, 2024
17 checks passed
@mmetc mmetc deleted the papi-msg branch January 22, 2024 12:25
sabban pushed a commit that referenced this pull request Jan 23, 2024
* make dev.yaml has a valid/default console path

* simplify and make more consistent help message about console opts

* allow enroll to specify options to enable

* allow 'all' shortcut for --enable

lapi/papi: when receiving alerts, log and discard invalid addr/range (#2708)

#2687

log "loading papi client" only if papi is enabled (#2762)

Appsec hooks fixes (#2769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants