-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[http] Add unix socket option #2764
[http] Add unix socket option #2764
Conversation
…tion with URL parameter as we dont know which path the user wants so if they would like to communicate over unix socket they need to use both, however, the hostname can be whatever they want. We could be a little smarter and actually parse the url, however, increasing code when a user can just define it correctly make no sense
@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2764 +/- ##
=======================================
Coverage 57.93% 57.93%
=======================================
Files 239 239
Lines 30983 30988 +5
=======================================
+ Hits 17950 17953 +3
- Misses 11399 11403 +4
+ Partials 1634 1632 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/kind enhancement |
Did you manage to test and review @mmetc |
Implement #2757
Add unix socket option to http plugin, we have to use this in conjunction with URL parameter as we dont know which path the user wants so if they would like to communicate over unix socket they need to use both, however, the hostname can be whatever they want. (All communication will be over the unix socket but we dont know the path or scheme and rather not add specific arguments just for that when they can define within URL param)
Example of pushing to Gotify over unix socket (Dont worry about token as it is just a local version)