Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple docker image from package release #2791

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Decouple docker image from package release #2791

merged 2 commits into from
Jan 29, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 29, 2024

  • entry point fixes for 1.6.0
  • correctly override BUILD_VERSION argument
  • manual release workflow

 - entry point fixes for 1.6.0
 - correctly override BUILD_VERSION argument
 - manual release workflow
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc changed the title Decouple docker version from package release Decouple docker image from package release Jan 29, 2024
@mmetc mmetc added the kind/enhancement New feature or request label Jan 29, 2024
@mmetc mmetc added needs/kind kind/fix and removed kind/enhancement New feature or request labels Jan 29, 2024
@mmetc mmetc requested a review from sabban January 29, 2024 16:19
@mmetc mmetc marked this pull request as ready for review January 29, 2024 16:20
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91b0fce) 56.90% compared to head (5c90b9f) 47.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2791      +/-   ##
==========================================
- Coverage   56.90%   47.77%   -9.14%     
==========================================
  Files         237      141      -96     
  Lines       30641    17843   -12798     
==========================================
- Hits        17437     8524    -8913     
+ Misses      11521     8393    -3128     
+ Partials     1683      926     -757     
Flag Coverage Δ
bats ?
unit-linux ?
unit-windows 47.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 311dfde into master Jan 29, 2024
16 checks passed
@mmetc mmetc deleted the docker-trigger branch January 29, 2024 21:05
@mmetc
Copy link
Contributor Author

mmetc commented Jan 30, 2024

fix #2786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants