Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact "cscli metrics" part 2 #2806

Merged
merged 5 commits into from
Feb 2, 2024
Merged

refact "cscli metrics" part 2 #2806

merged 5 commits into from
Feb 2, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 1, 2024

  • encapsulate globals
  • types and methods for each table

@mmetc mmetc added the kind/enhancement New feature or request label Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Feb 1, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.6.1 milestone Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (5ff8a03) 57.29% compared to head (b871843) 57.27%.

Files Patch % Lines
cmd/crowdsec-cli/metrics.go 25.92% 80 Missing ⚠️
cmd/crowdsec-cli/metrics_table.go 61.53% 1 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2806      +/-   ##
==========================================
- Coverage   57.29%   57.27%   -0.03%     
==========================================
  Files         238      238              
  Lines       30590    30584       -6     
==========================================
- Hits        17527    17516      -11     
- Misses      11413    11418       +5     
  Partials     1650     1650              
Flag Coverage Δ
bats 37.08% <32.83%> (+<0.01%) ⬆️
unit-linux 52.22% <ø> (-0.01%) ⬇️
unit-windows 47.76% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 81acad0 into master Feb 2, 2024
17 checks passed
@mmetc mmetc deleted the cscli-metrics-2 branch February 2, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants