cscli metrics: rename buckets -> scenarios

[mmetc]

No description provided.

[github-actions]

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (717fc97) 57.88% compared to head (8a35f78) 57.92%.

Files	Patch %	Lines
cmd/crowdsec-cli/metrics_table.go	33.33%	8 Missing ⚠️
cmd/crowdsec-cli/metrics.go	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2848      +/-   ##
==========================================
+ Coverage   57.88%   57.92%   +0.04%     
==========================================
  Files         239      239              
  Lines       30993    31005      +12     
==========================================
+ Hits        17941    17961      +20     
+ Misses      11415    11411       -4     
+ Partials     1637     1633       -4     

Flag	Coverage Δ
bats	37.85% <57.14%> (+0.06%)	⬆️
unit-linux	52.36% <ø> (+0.01%)	⬆️
unit-windows	47.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[LaurenceJJones]

Should it say lines poured to scenario?

│             Source             │ Lines read │ Lines parsed │ Lines unparsed │ Lines poured to bucket │ Lines whitelisted │
├────────────────────────────────┼────────────┼──────────────┼────────────────┼────────────────────────┼───────────────────┤
│ file:/var/log/nginx/access.log │ 5          │ 5            │ -              │ -                      │ 5                 │
╰────────────────────────────────┴────────────┴──────────────┴────────────────┴────────────────────────┴───────────────────╯

[mmetc]

Should it say lines poured to scenario?

│             Source             │ Lines read │ Lines parsed │ Lines unparsed │ Lines poured to bucket │ Lines whitelisted │
├────────────────────────────────┼────────────┼──────────────┼────────────────┼────────────────────────┼───────────────────┤
│ file:/var/log/nginx/access.log │ 5          │ 5            │ -              │ -                      │ 5                 │
╰────────────────────────────────┴────────────┴──────────────┴────────────────┴────────────────────────┴───────────────────╯

IMHO no, the sentence would not make sense.
Anyway the most important is the name in "metrics list" because it can go in scripts, we can change the others as needed.