Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acquisition : take prometheus level into account #2885

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Mar 12, 2024

properly take into account the aggregation level of prometheus metrics in the acquisition

Copy link

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 28.15534% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 47.42%. Comparing base (bd785ed) to head (ef9ca13).

Files Patch % Lines
pkg/acquisition/modules/s3/s3.go 6.66% 9 Missing and 5 partials ⚠️
pkg/acquisition/acquisition.go 50.00% 10 Missing ⚠️
pkg/acquisition/modules/kinesis/kinesis.go 0.00% 10 Missing ⚠️
pkg/acquisition/modules/syslog/syslog.go 18.18% 6 Missing and 3 partials ⚠️
pkg/acquisition/modules/file/file.go 40.00% 4 Missing and 2 partials ⚠️
...g/acquisition/modules/kubernetesaudit/k8s_audit.go 33.33% 4 Missing and 2 partials ⚠️
pkg/acquisition/modules/journalctl/journalctl.go 0.00% 5 Missing ⚠️
pkg/acquisition/modules/docker/docker.go 40.00% 2 Missing and 1 partial ⚠️
pkg/acquisition/modules/kafka/kafka.go 40.00% 3 Missing ⚠️
pkg/acquisition/modules/loki/loki.go 40.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2885       +/-   ##
===========================================
- Coverage   58.16%   47.42%   -10.75%     
===========================================
  Files         242      143       -99     
  Lines       31238    18152    -13086     
===========================================
- Hits        18171     8609     -9562     
+ Misses      11409     8584     -2825     
+ Partials     1658      959      -699     
Flag Coverage Δ
bats ?
unit-linux ?
unit-windows 47.42% <28.15%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor
Copy link
Contributor Author

buixor commented Mar 12, 2024

/area agent
/kind fix

pkg/acquisition/acquisition.go Outdated Show resolved Hide resolved
pkg/acquisition/acquisition.go Outdated Show resolved Hide resolved
@buixor buixor merged commit b1c09f7 into master Mar 13, 2024
15 checks passed
@buixor buixor deleted the fix_datasource_aggreg branch March 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants