Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli: remove global dbClient #2985

Merged
merged 2 commits into from
May 6, 2024
Merged

cscli: remove global dbClient #2985

merged 2 commits into from
May 6, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 6, 2024

No description provided.

Copy link

github-actions bot commented May 6, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented May 6, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc requested a review from blotus May 6, 2024 09:25
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 51.02041% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 27.61%. Comparing base (659feec) to head (e921250).

Files Patch % Lines
cmd/crowdsec-cli/papi.go 0.00% 7 Missing ⚠️
pkg/database/database.go 65.00% 6 Missing and 1 partial ⚠️
pkg/leakybucket/overflows.go 66.66% 5 Missing and 1 partial ⚠️
pkg/leakybucket/manager_run.go 0.00% 3 Missing ⚠️
cmd/crowdsec-cli/support.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2985   +/-   ##
=======================================
  Coverage   27.61%   27.61%           
=======================================
  Files         398      398           
  Lines       57895    57904    +9     
=======================================
+ Hits        15988    15992    +4     
- Misses      39954    39958    +4     
- Partials     1953     1954    +1     
Flag Coverage Δ
unit-linux 35.12% <0.00%> (+0.01%) ⬆️
unit-windows 25.66% <51.02%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit a2dcc0e into master May 6, 2024
15 checks passed
@mmetc mmetc deleted the cscli-db branch May 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants