CI/lint: enable some "revive" rules #3041
Conversation
|
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3041 +/- ##
=======================================
Coverage 52.38% 52.39%
=======================================
Files 280 280
Lines 35431 35431
=======================================
+ Hits 18560 18563 +3
+ Misses 15030 15028 -2
+ Partials 1841 1840 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
argument-limit Warns when a function receives more parameters than the maximum set by the rule's configuration. bare-return Warns on bare (a.k.a. naked) returns context-as-argument By convention, context.Context should be the first parameter of a function. duplicated-imports It is possible to unintentionally import the same package twice. modifies-parameter A function that modifies its parameters can be hard to understand. It can also be misleading if the arguments are passed by value by the caller. redundant-import-alias This rule warns on redundant import aliases. unreachable-code This rule spots and proposes to remove unreachable code.
argument-limit
Warns when a function receives more parameters than the maximum set by the rule's configuration.
bare-return
Warns on bare (a.k.a. naked) returns
context-as-argument
By convention, context.Context should be the first parameter of a function.
duplicated-imports
It is possible to unintentionally import the same package twice.
modifies-parameter
A function that modifies its parameters can be hard to understand. It can also be misleading if the arguments are passed by value by the caller.
redundant-import-alias
This rule warns on redundant import aliases.
unreachable-code
This rule spots and proposes to remove unreachable code.