Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint revive(deep-exit): refactor cmd/crowdsec #3063

Merged
merged 2 commits into from
Jun 7, 2024
Merged

lint revive(deep-exit): refactor cmd/crowdsec #3063

merged 2 commits into from
Jun 7, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 6, 2024

No description provided.

@mmetc mmetc added this to the 1.6.3 milestone Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 24 lines in your changes missing coverage. Please review.

Project coverage is 52.47%. Comparing base (6ef2396) to head (3482e4d).

Files Patch % Lines
cmd/crowdsec/dump.go 50.00% 12 Missing and 5 partials ⚠️
cmd/crowdsec/crowdsec.go 33.33% 5 Missing and 1 partial ⚠️
cmd/crowdsec/serve.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3063      +/-   ##
==========================================
+ Coverage   52.44%   52.47%   +0.03%     
==========================================
  Files         280      281       +1     
  Lines       35451    35423      -28     
==========================================
- Hits        18591    18589       -2     
+ Misses      15030    15010      -20     
+ Partials     1830     1824       -6     
Flag Coverage Δ
bats 40.18% <61.76%> (-0.02%) ⬇️
unit-linux 34.84% <0.00%> (+0.02%) ⬆️
unit-windows 30.96% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 550d422 into master Jun 7, 2024
17 checks passed
@mmetc mmetc deleted the deep-exit branch June 7, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants