Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update golangci-lint to 1.59; enforce canonical HTTP headers #3074

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 10, 2024

No description provided.

@mmetc mmetc added the dependencies Pull requests that update a dependency file label Jun 10, 2024
@mmetc mmetc added this to the 1.6.3 milestone Jun 10, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc changed the title CI: update golangci-lint to 1.59; enforce canonical headers CI: update golangci-lint to 1.59; enforce canonical HTTP headers Jun 10, 2024
@mmetc mmetc added kind/dependencies and removed dependencies Pull requests that update a dependency file labels Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.46%. Comparing base (819fa0e) to head (319cfb7).

Files Patch % Lines
cmd/notification-sentinel/main.go 0.00% 2 Missing ⚠️
cmd/crowdsec-cli/console.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3074      +/-   ##
==========================================
- Coverage   52.47%   52.46%   -0.02%     
==========================================
  Files         281      281              
  Lines       35429    35429              
==========================================
- Hits        18592    18588       -4     
- Misses      15012    15013       +1     
- Partials     1825     1828       +3     
Flag Coverage Δ
bats 40.21% <0.00%> (-0.02%) ⬇️
unit-linux 34.82% <25.00%> (ø)
unit-windows 30.95% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but was there a reason for canonical http headers are just to be RFC compliant?

@mmetc mmetc merged commit 7fd01ae into master Jun 10, 2024
17 checks passed
@mmetc mmetc deleted the lint-1.59 branch June 10, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants