Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli refact: extract table wrapper to own package #3105

Merged
merged 2 commits into from
Jul 4, 2024
Merged

cscli refact: extract table wrapper to own package #3105

merged 2 commits into from
Jul 4, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 4, 2024

No description provided.

Copy link

github-actions bot commented Jul 4, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jul 4, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 165 lines in your changes missing coverage. Please review.

Project coverage is 34.42%. Comparing base (9cebcf9) to head (5685cab).

Files Patch % Lines
cmd/crowdsec-cli/metrics_table.go 0.00% 55 Missing ⚠️
cmd/crowdsec-cli/cstable/cstable.go 0.00% 23 Missing ⚠️
cmd/crowdsec-cli/hubtest_table.go 0.00% 20 Missing ⚠️
cmd/crowdsec-cli/utils_table.go 0.00% 14 Missing ⚠️
cmd/crowdsec-cli/alerts.go 0.00% 7 Missing ⚠️
cmd/crowdsec-cli/alerts_table.go 0.00% 6 Missing ⚠️
cmd/crowdsec-cli/hubtest.go 0.00% 5 Missing ⚠️
cmd/crowdsec-cli/item_metrics.go 0.00% 5 Missing ⚠️
cmd/crowdsec-cli/machines.go 0.00% 5 Missing ⚠️
cmd/crowdsec-cli/items.go 0.00% 4 Missing ⚠️
... and 10 more

❗ There is a different number of reports uploaded between BASE (9cebcf9) and HEAD (5685cab). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (9cebcf9) HEAD (5685cab)
unit-windows 1 0
bats 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3105       +/-   ##
===========================================
- Coverage   49.87%   34.42%   -15.46%     
===========================================
  Files         305      248       -57     
  Lines       37657    25868    -11789     
===========================================
- Hits        18781     8904     -9877     
+ Misses      17053    15864     -1189     
+ Partials     1823     1100      -723     
Flag Coverage Δ
bats ?
unit-linux 34.42% <0.00%> (-0.02%) ⬇️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 90e3299 into master Jul 4, 2024
16 of 17 checks passed
@mmetc mmetc deleted the cstable branch July 4, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants