Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: dockerfiles #3138

Merged
merged 1 commit into from
Jul 18, 2024
Merged

lint: dockerfiles #3138

merged 1 commit into from
Jul 18, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 17, 2024

just the ones shown as warnings in the CI

@mmetc mmetc added this to the 1.6.3 milestone Jul 17, 2024
@mmetc mmetc requested a review from sabban July 17, 2024 10:43
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.64%. Comparing base (8d96ddd) to head (943d9df).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3138      +/-   ##
==========================================
- Coverage   49.65%   49.64%   -0.02%     
==========================================
  Files         322      322              
  Lines       37906    37906              
==========================================
- Hits        18823    18819       -4     
- Misses      17243    17245       +2     
- Partials     1840     1842       +2     
Flag Coverage Δ
bats 38.33% <ø> (+0.01%) ⬆️
unit-linux 34.23% <ø> (+<0.01%) ⬆️
unit-windows 28.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 443ec37 into master Jul 18, 2024
18 checks passed
@mmetc mmetc deleted the lint-docker branch July 18, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants