Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update expr #3144

Merged
merged 9 commits into from
Jul 22, 2024
Merged

update expr #3144

merged 9 commits into from
Jul 22, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented Jul 19, 2024

No description provided.

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.62%. Comparing base (35f97d4) to head (0d1163a).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/exprhelpers/debugger.go 91.11% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3144      +/-   ##
==========================================
- Coverage   49.66%   49.62%   -0.04%     
==========================================
  Files         322      322              
  Lines       37906    37891      -15     
==========================================
- Hits        18825    18803      -22     
- Misses      17242    17246       +4     
- Partials     1839     1842       +3     
Flag Coverage Δ
bats 38.37% <0.00%> (+<0.01%) ⬆️
unit-linux 34.15% <90.47%> (-0.08%) ⬇️
unit-windows 28.80% <91.11%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus
Copy link
Member Author

blotus commented Jul 22, 2024

/kind chore

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

pkg/exprhelpers/debugger.go Show resolved Hide resolved
pkg/exprhelpers/debugger.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blotus blotus merged commit a3d7900 into master Jul 22, 2024
17 checks passed
@blotus blotus deleted the update-expr branch July 22, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants