Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Remove useragent set by RC #3167

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

LaurenceJJones
Copy link
Contributor

@LaurenceJJones LaurenceJJones commented Aug 6, 2024

Fix #3166

Checked all currently supported remediation components (nginx, openresty and traefik) all currently support the new header the upcoming will need to ensure this is set.

/kind enhancement
/area agent

@github-actions github-actions bot added kind/enhancement New feature or request area/agent labels Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.78%. Comparing base (6bd4096) to head (2454bf1).

Files Patch % Lines
pkg/appsec/request.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3167      +/-   ##
==========================================
- Coverage   50.80%   50.78%   -0.02%     
==========================================
  Files         326      326              
  Lines       38623    38624       +1     
==========================================
- Hits        19621    19614       -7     
- Misses      17078    17083       +5     
- Partials     1924     1927       +3     
Flag Coverage Δ
bats 40.23% <0.00%> (+0.01%) ⬆️
unit-linux 33.94% <0.00%> (+<0.01%) ⬆️
unit-windows 28.39% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones merged commit 71a253a into master Aug 12, 2024
17 checks passed
@LaurenceJJones LaurenceJJones deleted the appsec_delete_rc_ua branch August 12, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AppSec] Unable to match empty user-agent
2 participants