Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli hub update: option --with-content to keep embedded items in index; use it in docker #3192

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Aug 26, 2024

No description provided.

@mmetc mmetc added this to the 1.6.4 milestone Aug 26, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 57.69231% with 11 lines in your changes missing coverage. Please review.

Project coverage is 50.97%. Comparing base (c4431b6) to head (99cb522).
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/cwhub/remote.go 50.00% 7 Missing and 2 partials ⚠️
cmd/crowdsec-cli/hub.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3192      +/-   ##
==========================================
+ Coverage   47.75%   50.97%   +3.21%     
==========================================
  Files         329      329              
  Lines       38660    38684      +24     
==========================================
+ Hits        18462    19719    +1257     
+ Misses      18354    17029    -1325     
- Partials     1844     1936      +92     
Flag Coverage Δ
bats 40.30% <78.94%> (-0.05%) ⬇️
unit-linux 34.53% <0.00%> (?)
unit-windows 28.58% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added the kind/enhancement New feature or request label Aug 26, 2024
@mmetc mmetc force-pushed the cscli-hub-update-with-content branch from d782d99 to 8ac6b4c Compare August 26, 2024 14:15
@mmetc mmetc force-pushed the cscli-hub-update-with-content branch from 8ac6b4c to 99cb522 Compare August 27, 2024 08:31
@mmetc mmetc merged commit ec415ed into master Aug 27, 2024
17 checks passed
@mmetc mmetc deleted the cscli-hub-update-with-content branch August 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants