Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli refact: extract packages ask, clientinfo #3197

Merged
merged 2 commits into from
Aug 28, 2024
Merged

cscli refact: extract packages ask, clientinfo #3197

merged 2 commits into from
Aug 28, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Aug 27, 2024

this is required to separate machines, bouncers, and support.

@mmetc mmetc added this to the 1.6.4 milestone Aug 27, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 43.90244% with 23 lines in your changes missing coverage. Please review.

Project coverage is 51.04%. Comparing base (2e970b3) to head (be99f2d).
Report is 1 commits behind head on master.

Files Patch % Lines
cmd/crowdsec-cli/ask/ask.go 0.00% 12 Missing ⚠️
cmd/crowdsec-cli/bouncers.go 33.33% 4 Missing ⚠️
cmd/crowdsec-cli/machines.go 42.85% 4 Missing ⚠️
cmd/crowdsec-cli/clientinfo/clientinfo.go 81.25% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3197   +/-   ##
=======================================
  Coverage   51.04%   51.04%           
=======================================
  Files         337      339    +2     
  Lines       38643    38643           
=======================================
+ Hits        19725    19726    +1     
  Misses      16984    16984           
+ Partials     1934     1933    -1     
Flag Coverage Δ
bats 40.41% <52.94%> (+0.01%) ⬆️
unit-linux 34.59% <0.00%> (+0.01%) ⬆️
unit-windows 28.63% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit eec32ad into master Aug 28, 2024
17 checks passed
@mmetc mmetc deleted the cli branch August 28, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants