Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: reduce code nesting (acquisition/file, tests) #3200

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Aug 29, 2024

No description provided.

@mmetc mmetc added this to the 1.6.4 milestone Aug 29, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 53.98230% with 52 lines in your changes missing coverage. Please review.

Project coverage is 51.09%. Comparing base (f0d6046) to head (20f28cd).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/file/file.go 51.38% 23 Missing and 12 partials ⚠️
cmd/crowdsec-cli/cliconsole/console.go 8.33% 11 Missing ⚠️
pkg/leakybucket/manager_load.go 79.31% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3200      +/-   ##
==========================================
- Coverage   51.10%   51.09%   -0.02%     
==========================================
  Files         339      339              
  Lines       38710    38714       +4     
==========================================
- Hits        19784    19782       -2     
- Misses      16982    16986       +4     
- Partials     1944     1946       +2     
Flag Coverage Δ
bats 40.53% <0.94%> (+0.02%) ⬆️
unit-linux 34.67% <51.88%> (-0.01%) ⬇️
unit-windows 28.60% <50.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from sabban August 29, 2024 12:01
@mmetc mmetc requested review from blotus and removed request for sabban September 3, 2024 09:18
@mmetc mmetc merged commit 5a50fd0 into master Sep 3, 2024
17 checks passed
@mmetc mmetc deleted the 1.6.4-nestif branch September 3, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants