Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: cscli papi #3222

Merged
merged 6 commits into from
Sep 10, 2024
Merged

refact: cscli papi #3222

merged 6 commits into from
Sep 10, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 10, 2024

No description provided.

@mmetc mmetc added this to the 1.6.4 milestone Sep 10, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 17.77778% with 74 lines in your changes missing coverage. Please review.

Project coverage is 51.23%. Comparing base (c8750f6) to head (c05a9da).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clipapi/papi.go 20.31% 49 Missing and 2 partials ⚠️
cmd/crowdsec-cli/clisupport/support.go 5.00% 18 Missing and 1 partial ⚠️
cmd/crowdsec-cli/require/require.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3222      +/-   ##
==========================================
+ Coverage   51.10%   51.23%   +0.13%     
==========================================
  Files         340      340              
  Lines       38739    38770      +31     
==========================================
+ Hits        19797    19865      +68     
+ Misses      16994    16944      -50     
- Partials     1948     1961      +13     
Flag Coverage Δ
bats 40.73% <23.52%> (+0.21%) ⬆️
unit-linux 34.66% <0.00%> (-0.02%) ⬇️
unit-windows 28.58% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review September 10, 2024 14:54
@mmetc mmetc merged commit 4d10e9d into master Sep 10, 2024
17 checks passed
@mmetc mmetc deleted the cscli-papi branch September 10, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants