Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context propagation: explicit ctx parameter in unit tests #3229

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 13, 2024

This is done so we can later enable a context linter.

This is done so we can later enable a context linter.
@mmetc mmetc added the kind/enhancement New feature or request label Sep 13, 2024
@mmetc mmetc added this to the 1.6.4 milestone Sep 13, 2024
@mmetc mmetc requested a review from blotus September 13, 2024 07:33
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.29%. Comparing base (b14201a) to head (ddd5c11).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3229      +/-   ##
==========================================
- Coverage   51.30%   51.29%   -0.02%     
==========================================
  Files         355      355              
  Lines       38847    38847              
==========================================
- Hits        19932    19928       -4     
- Misses      16953    16954       +1     
- Partials     1962     1965       +3     
Flag Coverage Δ
bats 40.91% <ø> (-0.03%) ⬇️
unit-linux 34.70% <ø> (+0.02%) ⬆️
unit-windows 28.61% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 7c5d4d8 into master Sep 19, 2024
17 checks passed
@mmetc mmetc deleted the context-propagation branch September 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants