Init #1
Merged
Init #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlteredCoder
requested changes
Jul 26, 2023
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
|
@AlteredCoder done via c5cd555 |
|
Several configuration options take the name from the legacy cloudflare bouncer, which sets them apart from the other bouncers. Example: crowdsec_lapi_url, log_mode vs log_media etc. It would be nice to have some consistency and predictability -- for ease of use and to minimize differences in the build/install/configuration scripts Same for the defaults: should bouncers by default log to stderr or file? etc |
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
|
@mmetc thanks for the review. I've updated the config to be same as cs-blocklist-mirror |
mmetc
reviewed
Aug 31, 2023
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
rr404
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.