-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate limit calls to airtable #1
Comments
@mjmaurer How do you feel about caching this? I could set it up to rate limit and cache the results in-process, that should free up more of the quota for the other things airtable is/is going to be used for. edit: ahh missed the link. By 'this' I meant... this https://github.com/crownheightsaid/slack-app/blob/master/src/airtable.js#L7 |
great! feel free to go for. try and keep the api in airtable.js as much as possible |
@mjmaurer is this sill an issue? |
Yup! Honestly surprised we haven't really run into it. I don't think the rate limit is as advertised. There have been times where we clearly went over the rate limit and nothing seemed to happen. (ex: when fixing a bug in the airtable change detector which triggers a large backfill) |
Update, after speaking in MM, this is something that could happen since nothing is stopping it. So far, so good though. -> not a high priority. |
We get 5 req per sec. This looks like a good bet. Probably cant just use a global middleware: https://github.com/nfriedly/express-rate-limit
The text was updated successfully, but these errors were encountered: