88 table view #104

allthesignals · 2020-06-23T19:33:02Z

Addresses #88

Adds a table to display deliveries along with hyperlink. Does not paginate, but prevents table row overflow.

Next steps are to hook up the map so that rows highlight on hover.

piratefsh

I have some comments but overall this looks dope! It's going to be really useful as we see increased deliveries from the temporary phone line closure to clear our queue.

Per the ticket #88, can you also add more fields as posted in #community_needs? The more fleshed out the table is, the easier it is for volunteers to decide what they can pick up. This includes household size, language, description, etc. which are particularly important for deciding how big a job will be.

All of this data isn't in the payload for the map but should be pretty easy to add on from the API. This can happen in a separate PR as well if you want to keep this one small!

Thank you for your contribution!

piratefsh · 2020-06-23T22:59:43Z

src/webapp/DEVELOPING.md

+It's easy to run the app, but some features require additional configuration.
+
+### Mapbox API Key


This can be fetched from our staging heroku as well. folks can reach out for access in #wg_tech

piratefsh · 2020-06-23T23:00:34Z

src/webapp/components/DeliveryTable.js

+        <TableHead>
+          <TableRow>
+            <TableCell>Code</TableCell>
+            <TableCell align="right">Cross Street #1</TableCell>


We should be using str translations here as well. See README for details on how to add i18n.

These strings in particular might already exist in the webapp namespace!

allthesignals · 2020-06-25T19:01:41Z

I have some comments but overall this looks dope! It's going to be really useful as we see increased deliveries from the temporary phone line closure to clear our queue.

Per the ticket #88, can you also add more fields as posted in #community_needs? The more fleshed out the table is, the easier it is for volunteers to decide what they can pick up. This includes household size, language, description, etc. which are particularly important for deciding how big a job will be.

All of this data isn't in the payload for the map but should be pretty easy to add on from the API. This can happen in a separate PR as well if you want to keep this one small!

Thank you for your contribution!

Thanks, I'll address all of these ASAP!

mjmaurer · 2020-06-26T17:06:25Z

I have a bigger ask that would be SUPER useful. would it be possible to sort open requests by time since the slack post? (and also display the lapsed time)

The message ts field which is used as a thread ID is also a Unix timestamp (https://www.unixtimestamp.com/index.php), so there wouldn't need to be any extra network calls

This would be a good supplement to #63

allthesignals · 2020-06-26T17:34:19Z

I have a bigger ask that would be SUPER useful. would it be possible to sort open requests by time since the slack post? (and also display the lapsed time)

The message ts field which is used as a thread ID is also a Unix timestamp (https://www.unixtimestamp.com/index.php), so there wouldn't need to be any extra network calls

This would be a good supplement to #63

You bet! I think I can work on this tomorrow if that's alright. I realize the table needs a lot more work before it'll be useful.

piratefsh · 2020-06-26T17:46:35Z

good idea re: sorting! i also think its ok to ship a minimum version like what we have right now and iterate on it. keeps PRs small and easier to review as well.

…

On Fri, Jun 26, 2020, at 1:34 PM, Matt Gardner wrote: > I have a bigger ask that would be SUPER useful. would it be possible to sort open requests by time since the slack post? (and also display the lapsed time) > The message `ts` field which is used as a thread ID is also a Unix timestamp (https://www.unixtimestamp.com/index.php), so there wouldn't need to be any extra network calls > This would be a good supplement to #63 <#63> You bet! I think I can work on this tomorrow if that's alright. I realize the table needs a lot more work before it'll be useful. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#104 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOIE4DSC3TOGKPGHUZLJE3RYTL2RANCNFSM4OF7EH7A>.

piratefsh · 2020-06-26T17:47:06Z

as long as we communicate with volunteers whats going on, we should be good to take an iterative approach.

…

On Fri, Jun 26, 2020, at 1:46 PM, Sher Minn Chong wrote: good idea re: sorting! i also think its ok to ship a minimum version like what we have right now and iterate on it. keeps PRs small and easier to review as well. On Fri, Jun 26, 2020, at 1:34 PM, Matt Gardner wrote: > >> I have a bigger ask that would be SUPER useful. would it be possible to sort open requests by time since the slack post? (and also display the lapsed time) >> The message `ts` field which is used as a thread ID is also a Unix timestamp (https://www.unixtimestamp.com/index.php), so there wouldn't need to be any extra network calls >> This would be a good supplement to #63 <#63> > You bet! I think I can work on this tomorrow if that's alright. I realize the table needs a lot more work before it'll be useful. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub <#104 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOIE4DSC3TOGKPGHUZLJE3RYTL2RANCNFSM4OF7EH7A>. >

mjmaurer · 2020-06-26T18:56:56Z

Yup feel free to do a different PR. Does this PR have an associated issue that I'm missing?

allthesignals · 2020-06-26T19:02:49Z

#88

allthesignals · 2020-07-02T18:16:17Z

@mjmaurer I'm currently out of town dealing with a family matter — if someone wants to finish this before I am able to get back, that's totally fine

mjmaurer · 2020-07-03T01:59:44Z

any eta? I might be able to take this up and I'll try to make sure the commits remain yours

piratefsh · 2020-07-08T18:32:47Z

In the interest of moving forward with this feature, imma propose that we address existing issues from comments above, assess if it is safe and helpful to go to prod and iterate from there. wdyt?

thanks @allthesignals for starting the work. I'm happy to take over this PR from here if no one else wants to.

mjmaurer · 2020-07-09T02:17:19Z

makes sense to me!

allthesignals · 2020-07-16T19:27:42Z

Sorry @mjmaurer @piratefsh , I'm still away dealing with some issues. I could look at it late next week at the earliest. I have no problem with anyone who wants to take it over.

allthesignals · 2020-07-18T18:23:52Z

Looking at this again. Rebased with changes, a few merge conflicts.

To sort by slack post, I'll need to figure out how to get that data in.

allthesignals · 2020-07-18T19:15:10Z

Oh woops let me get the str changes in

Includes changes to the grid system so that the table and explainer text can show in the same view.

Replaces the ts-react-json-table dependency with material-ui, which is already installed and available.

mjmaurer

Only one comment. thanks so much!

mjmaurer · 2020-07-23T01:03:57Z

src/webapp/components/DeliveryTable.js

+          {formattedRows.map((row) => (
+            <TableRow key={row.Code}>
+              <TableCell component="th" scope="row">
+                {row.Code}


can you replace these row field strings with those in lib/airtable/tables/requests?

@mjmaurer sure! But how do I import ~airtable/tables/requests into the react app?

If I follow, we're using these row field strings to avoid weird property names ("Cross Street #1").

import Requests from "~airtable/tables/requests"; throws

Module not found: Can't resolve '~airtable/tables/requests' in '/Users/wmattgardner/mutual-aid-app/src/webapp/components'

Importing with relative path throws errors about the dependencies of the thing being imported.

Any ideas? Am I totally missing something? Thanks!

hey @alllthesignals! Michael is out atm, Sherminn here. I think we probably don't have path aliasing set up for the react app, so you might just have to use relative path e.g. ../../lib/airtable. Since this is non-blocking, plus we have other places in the webapp where we need to fix this, im going to go ahead and merge this first and follow up with a new issue to handle hardcoding of airtable field keys.

This table view will be important for the upcoming work for #122, where volunteers can pick up delivery straight from the map. thank you for your contribution!

piratefsh

approved with ticket here to follow up on hardcoded strings here: #124

this will unblock SMS delivery pickup work! #122

piratefsh requested changes Jun 23, 2020

View reviewed changes

allthesignals force-pushed the 88-table-view branch from 8bb6e1e to 2eb9153 Compare July 18, 2020 18:21

allthesignals force-pushed the 88-table-view branch from 06ef4fa to 93242b0 Compare July 18, 2020 19:13

allthesignals requested review from mjmaurer and piratefsh July 18, 2020 19:14

allthesignals force-pushed the 88-table-view branch from 2b221d1 to 2d7cace Compare July 18, 2020 19:33

allthesignals added 6 commits July 18, 2020 16:37

Create DeliveryTable component; Add to DeliveryNeeded

dc3c9cb

Includes changes to the grid system so that the table and explainer text can show in the same view.

Swap out table dep for already-installed Material

79aa9db

Replaces the ts-react-json-table dependency with material-ui, which is already installed and available.

Provide timestamp data in API response

e76e08a

Sort by and show epoch timestamp, descending

bea6f10

Format timestamp for readability

526fe5c

Add i18 for table column names

b02423c

allthesignals force-pushed the 88-table-view branch from 2d7cace to b02423c Compare July 18, 2020 21:37

mjmaurer requested changes Jul 23, 2020

View reviewed changes

piratefsh approved these changes Aug 1, 2020

View reviewed changes

Merge branch 'master' into 88-table-view

9136ee4

piratefsh merged commit 05759ac into crownheightsaid:master Aug 1, 2020

piratefsh mentioned this pull request Aug 1, 2020

Clicking on request in table view should highlight request on map and vice versa #125

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

88 table view #104

88 table view #104

allthesignals commented Jun 23, 2020

piratefsh left a comment

piratefsh Jun 23, 2020

piratefsh Jun 23, 2020

mjmaurer Jun 25, 2020

allthesignals commented Jun 25, 2020

mjmaurer commented Jun 26, 2020 •

edited

Loading

allthesignals commented Jun 26, 2020

piratefsh commented Jun 26, 2020 via email

piratefsh commented Jun 26, 2020 via email

mjmaurer commented Jun 26, 2020

allthesignals commented Jun 26, 2020

allthesignals commented Jul 2, 2020

mjmaurer commented Jul 3, 2020

piratefsh commented Jul 8, 2020

mjmaurer commented Jul 9, 2020

allthesignals commented Jul 16, 2020

allthesignals commented Jul 18, 2020

allthesignals commented Jul 18, 2020

mjmaurer left a comment

mjmaurer Jul 23, 2020

allthesignals Jul 23, 2020 •

edited

Loading

piratefsh Aug 1, 2020

piratefsh left a comment

		It's easy to run the app, but some features require additional configuration.

		### Mapbox API Key

88 table view #104

88 table view #104

Conversation

allthesignals commented Jun 23, 2020

piratefsh left a comment

Choose a reason for hiding this comment

piratefsh Jun 23, 2020

Choose a reason for hiding this comment

piratefsh Jun 23, 2020

Choose a reason for hiding this comment

mjmaurer Jun 25, 2020

Choose a reason for hiding this comment

allthesignals commented Jun 25, 2020

mjmaurer commented Jun 26, 2020 • edited Loading

allthesignals commented Jun 26, 2020

piratefsh commented Jun 26, 2020 via email

piratefsh commented Jun 26, 2020 via email

mjmaurer commented Jun 26, 2020

allthesignals commented Jun 26, 2020

allthesignals commented Jul 2, 2020

mjmaurer commented Jul 3, 2020

piratefsh commented Jul 8, 2020

mjmaurer commented Jul 9, 2020

allthesignals commented Jul 16, 2020

allthesignals commented Jul 18, 2020

allthesignals commented Jul 18, 2020

mjmaurer left a comment

Choose a reason for hiding this comment

mjmaurer Jul 23, 2020

Choose a reason for hiding this comment

allthesignals Jul 23, 2020 • edited Loading

Choose a reason for hiding this comment

piratefsh Aug 1, 2020

Choose a reason for hiding this comment

piratefsh left a comment

Choose a reason for hiding this comment

mjmaurer commented Jun 26, 2020 •

edited

Loading

allthesignals Jul 23, 2020 •

edited

Loading