Replace hardcoded keys with the centralized list of Airtable keys #153
Conversation
| @@ -1,6 +1,6 @@ | |||
| const { merge } = require("lodash"); | |||
| const _ = require("lodash"); | |||
| const { airbase } = require("~airtable/bases"); | |||
| const { airbase } = require("../bases"); | |||
There was a problem hiding this comment.
For some reason I had to make this a relative path. The tilde path threw an error.
There was a problem hiding this comment.
very weird! do you remember the error? this should be currently in prod right?
There was a problem hiding this comment.
Yeah, super weird! The version with the tilde path is in prod, which proves that it works. Maybe this is just user error on my part.
Here's the error: Module not found: Can't resolve '~airtable/bases' in '/Users/emmasmith/projects/mutual-aid-app/src/lib/airtable/tables'
I see this when I run npm run local:react. Also when I try to build for prod using npm run build. The Express app runs just fine. It seems that the React side of things is not respecting the moduleAliases.
Clues, advice, guidance most appreciated :)
| @@ -12,6 +12,7 @@ import HouseholdSizeChip from "./HouseholdSizeChip"; | |||
| import DrivingClusterChip from "./DrivingClusterChip"; | |||
| import { daysSinceSlackMessage } from "../helpers/time"; | |||
| import ClusterMapContext from "../context/ClusterMapContext"; | |||
| import { fields } from "../../lib/airtable/tables/requests"; | |||
There was a problem hiding this comment.
Same here: the absolute path (with or without tilde) didn't work.
There was a problem hiding this comment.
Possibly this is old news, but after looking over it, it looks like the ~whatever module aliases aren't in use anywhere in the webapp directory... surprising! But I think that at least means that this problem isn't because of any change in this PR.
There was a problem hiding this comment.
Also, it looks like most of the other scripts in our package.json are requiring module-alias/register which I assume is what's giving other scripts the ability to resolve those aliases. However, I'm not actually sure how to do that in local:react since it runs react-scripts instead of node.
yes please! |
Resolves #124