Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Emote Popups and Animation Component #36

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

Tiranthine
Copy link
Collaborator

@Tiranthine Tiranthine commented Apr 4, 2024

This request contains two unrelated features.

First, an update of the emote popups.

  • Emotes jump higher now so the bigger emotes don't get clipped off by the bottom of the overlay
  • Added a new emote zone that adjusts the amount of emotes that jump based of their recent usage (zone location bottomEdgeMultiple). This was requested by Penflash.
  • Made the entire emote functionality more expandable for the future

Secondly, I adjusted the animation-component. This happened after Zendikar voiced some bugs with the previous implementation.

  • The animation-component was renamed to animation-host-component
  • The animation feature now spawns a new subcomponent that contains the image or video (akin to how the emote popups work)
  • The duration parameter is now considered to be in miliseconds
  • Added a video tag so both image and video resources are supported
  • The content should no longer be cached to prevent an animation looping in the background
  • Feature waits until resource is loaded before starting display (this is more interesting if the content is loaded from a server on another continent for example, since I experienced some big lagspikes in animated APNGs or GIFs)

Made Emotes jump higher on average
Added emote zone that adjusts amounts of emotes displayed based on usage
Duration is now in ms
Display waits for content loaded
Supports image and video types
@DarkView DarkView merged commit 81c97e9 into crscillitoe:main Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants