-
Notifications
You must be signed in to change notification settings - Fork 0
[CRT-186] Update Task Bank Design #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CRT-186] Update Task Bank Design #380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 10 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="frontend/src/components/Breadcrumbs.tsx">
<violation number="1" location="frontend/src/components/Breadcrumbs.tsx:34">
Wrapping the breadcrumb items in `HStack` introduces a `<div>` directly under the `<ol>` produced by `Breadcrumb.List`, so the `<li>` elements from `BreadcrumbItem` are no longer valid list children. Please remove this wrapper or restyle the list without inserting non-`li` nodes between the list and its items.</violation>
</file>
<file name="frontend/src/components/task/TaskTable.tsx">
<violation number="1" location="frontend/src/components/task/TaskTable.tsx:38">
Quick action controls are rendered with a styled Icon (svg) instead of a button, so they lack keyboard focus/activation semantics and regress accessibility.</violation>
<violation number="2" location="frontend/src/components/task/TaskTable.tsx:103">
Name column uses accessorKey "name" even though ExistingTask only exposes title, so sorting/filtering see undefined values and stop working.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| </Fragment> | ||
| ); | ||
| })} | ||
| <StyledHStack> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping the breadcrumb items in HStack introduces a <div> directly under the <ol> produced by Breadcrumb.List, so the <li> elements from BreadcrumbItem are no longer valid list children. Please remove this wrapper or restyle the list without inserting non-li nodes between the list and its items.
Prompt for AI agents
Address the following comment on frontend/src/components/Breadcrumbs.tsx at line 34:
<comment>Wrapping the breadcrumb items in `HStack` introduces a `<div>` directly under the `<ol>` produced by `Breadcrumb.List`, so the `<li>` elements from `BreadcrumbItem` are no longer valid list children. Please remove this wrapper or restyle the list without inserting non-`li` nodes between the list and its items.</comment>
<file context>
@@ -1,51 +1,54 @@
- </Fragment>
- );
- })}
+ <StyledHStack>
+ <BreadcrumbItem href="/">
+ <Icon as={LuHouse} />
</file context>
| } | ||
| `; | ||
|
|
||
| const StyledIconButton = styled(Icon)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick action controls are rendered with a styled Icon (svg) instead of a button, so they lack keyboard focus/activation semantics and regress accessibility.
Prompt for AI agents
Address the following comment on frontend/src/components/task/TaskTable.tsx at line 38:
<comment>Quick action controls are rendered with a styled Icon (svg) instead of a button, so they lack keyboard focus/activation semantics and regress accessibility.</comment>
<file context>
@@ -1,46 +1,64 @@
+ }
+`;
+
+const StyledIconButton = styled(Icon)`
+ background-color: var(--icon-button-background-color);
+ cursor: pointer;
</file context>
| }, | ||
| }, | ||
| { | ||
| accessorKey: "name", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name column uses accessorKey "name" even though ExistingTask only exposes title, so sorting/filtering see undefined values and stop working.
Prompt for AI agents
Address the following comment on frontend/src/components/task/TaskTable.tsx at line 103:
<comment>Name column uses accessorKey "name" even though ExistingTask only exposes title, so sorting/filtering see undefined values and stop working.</comment>
<file context>
@@ -56,147 +74,128 @@ const messages = defineMessages({
+ },
+ },
+ {
+ accessorKey: "name",
+ header: intl.formatMessage(messages.nameColumn),
+ cell: (info) => (
</file context>
| accessorKey: "name", | |
| accessorKey: "title", |
d336421 to
b652cc3
Compare
cfb72e4 to
5593f1e
Compare
b652cc3 to
8d301d8
Compare
5f62710 to
91a8613
Compare
8d301d8 to
5072868
Compare
1170a86 to
6237d23
Compare
You can find below a screenshot of the updated UI:
Summary by cubic
Updated the Task Bank UI with icon-based breadcrumbs and a Chakra-powered table to make browsing tasks simpler and faster. Aligns with CRT-186 by not showing associated lessons on the Task Bank screen.
New Features
Refactors
Written for commit 6237d23. Summary will update automatically on new commits.