Skip to content

Conversation

@Tyratox
Copy link
Contributor

@Tyratox Tyratox commented Nov 17, 2025

Summary by cubic

Updates the task list and progress experience with new task-instance pages, clearer status indicators, anonymization controls, and streamlined navigation. Aligns session and task views under a consistent Chakra-based UI.

  • New Features

    • Added task-instance pages: list, details, reference solutions, and per-task progress with tabbed navigation.
    • Show student task status (Not Started, Incomplete, Complete) using solution tests; Extended ExistingStudentSolution to include tests.
    • Rebuilt session progress table with Chakra DataTable; task headers link to per-task progress; added row action to view student details.
    • Added AnonymizationToggle and surfaced it on progress pages.
    • Added actions menus: copy lesson link (teacher only), delete lesson, and delete task.
  • Refactors

    • Switched from PrimeReact DataTable to Chakra DataTable; default hides search bar with targeted overrides.
    • Updated navigation and breadcrumbs icons and styling; simplified SessionNavigation tabs (Lesson Details, Tasks, Progress).
    • Theme updates: renamed table recipe, added menu recipe, introduced neutral status color, adjusted anchor styles.
    • Simplified solutions hook (removed lazy-table variant); added useTaskInstances to filter tasks by session.
    • PageHeading now supports an actions slot to place contextual menus next to titles.

Written for commit 2ab0ded. Summary will update automatically on new commits.

@Tyratox Tyratox self-assigned this Nov 17, 2025
@Tyratox Tyratox changed the base branch from feature/CRT-178_lesson_list_design to feature/CRT-190_progress_view_design November 17, 2025 22:28
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 16 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="frontend/src/components/ui/Theme.ts">

<violation number="1" location="frontend/src/components/ui/Theme.ts:161">
Removing the default underline from every anchor while also inheriting the surrounding text color eliminates all non-color indicators that text is clickable, which makes links indistinguishable from plain text until hovered and violates WCAG 1.4.1 (Use of Color). Please keep a persistent underline or another non-color affordance on links.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

a: {
// These are necessary as long as we still have the bootstrap styles imported
color: "inherit !important",
textDecoration: "none !important",
Copy link

@cubic-dev-ai cubic-dev-ai bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the default underline from every anchor while also inheriting the surrounding text color eliminates all non-color indicators that text is clickable, which makes links indistinguishable from plain text until hovered and violates WCAG 1.4.1 (Use of Color). Please keep a persistent underline or another non-color affordance on links.

Prompt for AI agents
Address the following comment on frontend/src/components/ui/Theme.ts at line 161:

<comment>Removing the default underline from every anchor while also inheriting the surrounding text color eliminates all non-color indicators that text is clickable, which makes links indistinguishable from plain text until hovered and violates WCAG 1.4.1 (Use of Color). Please keep a persistent underline or another non-color affordance on links.</comment>

<file context>
@@ -156,7 +156,9 @@ const config = defineConfig({
     a: {
+      // These are necessary as long as we still have the bootstrap styles imported
       color: &quot;inherit !important&quot;,
+      textDecoration: &quot;none !important&quot;,
       _hover: {
         textDecoration: &quot;underline&quot;,
</file context>
Suggested change
textDecoration: "none !important",
textDecoration: "underline !important",
Fix with Cubic

Base automatically changed from feature/CRT-190_progress_view_design to feature/CRT-197_ChakraUIIntegration November 18, 2025 07:23
@Tyratox Tyratox merged commit 6aefa9b into feature/CRT-197_ChakraUIIntegration Nov 18, 2025
1 of 2 checks passed
@Tyratox Tyratox deleted the feature/CRT-185_task_list branch November 18, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants