Various fixes #411
Merged
Various fixes #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Folder src/i18n was not being parsed
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 issues found across 18 files
Prompt for AI agents (all 6 issues)
Understand the root cause of the following 6 issues and fix them.
<file name="frontend/content/locales/fr.json">
<violation number="1" location="frontend/content/locales/fr.json:661">
The French description for `ListClasses.pageDescription` uses incorrect gender agreement (“créés”, “donné”), resulting in ungrammatical UI text. Please adjust the participles to match the feminine nouns.</violation>
</file>
<file name="frontend/src/components/session/SessionActions.tsx">
<violation number="1" location="frontend/src/components/session/SessionActions.tsx:112">
`values.link` never renders because the underlying message strings lack a `{link}` placeholder, so the Share modal drops the intended detail link.</violation>
</file>
<file name="frontend/content/compiled-locales/fr.json">
<violation number="1" location="frontend/content/compiled-locales/fr.json:221">
Spell “réessayer” correctly in this error message (no hyphen, accented é) to provide proper French text.</violation>
<violation number="2" location="frontend/content/compiled-locales/fr.json:1621">
Correct the spelling of “réessayer” in this error message to avoid a French typo.</violation>
<violation number="3" location="frontend/content/compiled-locales/fr.json:1949">
Use the correct imperative “Authentifie-toi” in this message to avoid a French grammar mistake.</violation>
<violation number="4" location="frontend/content/compiled-locales/fr.json:2027">
Fix the typo in “réessayer” and apply proper French punctuation (space before “!”) in this error message.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| }, | ||
| "ListClasses.pageDescription": { | ||
| "message": "" | ||
| "message": "Cette page affiche les classes que vous avez créés. Cliquez sur une classe donné pour modifier les leçons et voir les progrès de vos élèves." |
There was a problem hiding this comment.
The French description for ListClasses.pageDescription uses incorrect gender agreement (“créés”, “donné”), resulting in ungrammatical UI text. Please adjust the participles to match the feminine nouns.
Prompt for AI agents
Address the following comment on frontend/content/locales/fr.json at line 661:
<comment>The French description for `ListClasses.pageDescription` uses incorrect gender agreement (“créés”, “donné”), resulting in ungrammatical UI text. Please adjust the participles to match the feminine nouns.</comment>
<file context>
@@ -597,14 +648,20 @@
},
"ListClasses.pageDescription": {
- "message": ""
+ "message": "Cette page affiche les classes que vous avez créés. Cliquez sur une classe donné pour modifier les leçons et voir les progrès de vos élèves."
},
"ListClasses.pageTitle": {
</file context>
Suggested change
| "message": "Cette page affiche les classes que vous avez créés. Cliquez sur une classe donné pour modifier les leçons et voir les progrès de vos élèves." | |
| "message": "Cette page affiche les classes que vous avez créées. Cliquez sur une classe donnée pour modifier les leçons et voir les progrès de vos élèves." |
| {...(session?.isAnonymous | ||
| ? SessionShareMessages.shareModalAnonymousLessonInfo | ||
| : SessionShareMessages.shareModalPrivateLessonInfo)} | ||
| values={{ |
There was a problem hiding this comment.
values.link never renders because the underlying message strings lack a {link} placeholder, so the Share modal drops the intended detail link.
Prompt for AI agents
Address the following comment on frontend/src/components/session/SessionActions.tsx at line 112:
<comment>`values.link` never renders because the underlying message strings lack a `{link}` placeholder, so the Share modal drops the intended detail link.</comment>
<file context>
@@ -105,16 +88,43 @@ const SessionActions = ({
+ {...(session?.isAnonymous
+ ? SessionShareMessages.shareModalAnonymousLessonInfo
+ : SessionShareMessages.shareModalPrivateLessonInfo)}
+ values={{
+ link: (chunks) => (
+ <Link
</file context>
| { | ||
| "type": 0, | ||
| "value": "There was an error deleting the task. Please try again!" | ||
| "value": "Une erreur est survenue lors de l'effacement de l'activité. Merci de re-essayer!" |
There was a problem hiding this comment.
Fix the typo in “réessayer” and apply proper French punctuation (space before “!”) in this error message.
Prompt for AI agents
Address the following comment on frontend/content/compiled-locales/fr.json at line 2027:
<comment>Fix the typo in “réessayer” and apply proper French punctuation (space before “!”) in this error message.</comment>
<file context>
@@ -1834,43 +2000,43 @@
{
"type": 0,
- "value": "There was an error deleting the task. Please try again!"
+ "value": "Une erreur est survenue lors de l'effacement de l'activité. Merci de re-essayer!"
}
],
</file context>
| { | ||
| "type": 0, | ||
| "value": "Une erreur s'est produite lors de la suppression de la leçon. Veuillez réessayer !" | ||
| "value": "Une erreur est survenue lors de l'effacement de la leçon. Veuillez re-essayer." |
There was a problem hiding this comment.
Correct the spelling of “réessayer” in this error message to avoid a French typo.
Prompt for AI agents
Address the following comment on frontend/content/compiled-locales/fr.json at line 1621:
<comment>Correct the spelling of “réessayer” in this error message to avoid a French typo.</comment>
<file context>
@@ -1449,46 +1591,46 @@
{
"type": 0,
- "value": "Une erreur s'est produite lors de la suppression de la leçon. Veuillez réessayer !"
+ "value": "Une erreur est survenue lors de l'effacement de la leçon. Veuillez re-essayer."
}
],
</file context>
| "ClassDeleteModal.error": [ | ||
| { | ||
| "type": 0, | ||
| "value": "Une erreur est survenue lors de l'effacement de la classe. Veuillez re-essayer." |
There was a problem hiding this comment.
Spell “réessayer” correctly in this error message (no hyphen, accented é) to provide proper French text.
Prompt for AI agents
Address the following comment on frontend/content/compiled-locales/fr.json at line 221:
<comment>Spell “réessayer” correctly in this error message (no hyphen, accented é) to provide proper French text.</comment>
<file context>
@@ -185,10 +191,46 @@
+ "ClassDeleteModal.error": [
+ {
+ "type": 0,
+ "value": "Une erreur est survenue lors de l'effacement de la classe. Veuillez re-essayer."
+ }
+ ],
</file context>
Suggested change
| "value": "Une erreur est survenue lors de l'effacement de la classe. Veuillez re-essayer." | |
| "value": "Une erreur est survenue lors de l'effacement de la classe. Veuillez réessayer." |
| { | ||
| "type": 0, | ||
| "value": "Please authenticate below to access your lesson." | ||
| "value": "Authentifies-toi ci-dessous pour accéder à la leçon." |
There was a problem hiding this comment.
Use the correct imperative “Authentifie-toi” in this message to avoid a French grammar mistake.
Prompt for AI agents
Address the following comment on frontend/content/compiled-locales/fr.json at line 1949:
<comment>Use the correct imperative “Authentifie-toi” in this message to avoid a French grammar mistake.</comment>
<file context>
@@ -1780,13 +1946,13 @@
{
"type": 0,
- "value": "Please authenticate below to access your lesson."
+ "value": "Authentifies-toi ci-dessous pour accéder à la leçon."
}
],
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds delete confirmation modals for classes and lessons, introduces a lesson share modal, standardizes sharing types (anonymous/private), updates translations, and tweaks dashboard/table layout for better small‑screen support.
New Features
Refactors
Written for commit d8a2ff1. Summary will update automatically on new commits.