os error 87

[ToMattBan]

Describe the bug
I'm trying to download "Jobless Reincarnation" with dual audio and brazilian subtitle, but it always five me this error after donwloading video and audio. It says incorrect parameters.

To Reproduce
Steps / command to reproduce the behavior:

$ crunchy archive -a ja-JP -a pt-BR -s pt-BR -m audio -o "../_Novos/Mushoku Tensei: Jobless Reincarnation (2021) {tmdb-371310}/S{season_number} E{episode_number} - {title}-org.mkv" https://www.crunchyroll.com/series/G24H1N3MP/mushoku-tensei-jobless-reincarnation[S01E01-E100,S02-S50]

Expected behavior
Donwload the anime, with audio in Japanese and Portuguese and Brazilian subtitles.

Client (please complete the following information):

• OS: Win10
• Version 3.0.3

[valentinegb]

I was unable to reproduce this on macOS 14.1 Beta (23B5067a) using the latest commit of crunchy-cli (5bc68ad), I installed two episodes before I interrupted the command.

[bytedream]

This is a Windows specific error. When looking for the error on the internet and given that I cannot reproduce this on Linux too, the cause is probably that the underlying ffmpeg command is too long for Windows (once again a weird windows-only edgecase 🙃).
The command can be shortened down by using ffmpegs' -f concat input flag, I can see if it really works/fix it later today.

[ToMattBan]

=P
I will get the linux version then and run in my other computer

@bytedream if you want me to test something here on Windows, just ask.

[valentinegb]

(once again a weird windows-only edgecase 🙃)

Gotta love those Windows-only bugs lol

[bytedream]

Gotta love those Windows-only bugs lol

Yes windows got me once or twice with its weird behavior (e.g. d090a5a I was so pissed when I did this commit)

[bytedream]

So I've tried the command on a Windows VM and I also got an error but with a different error code. The cause may not be the length of the underlying command but special characters in the filename which are forbidden on Windows (there are plenty). Could you re-try the command without any of the colon : character in the filename @ToMattBan?

[ToMattBan]

Ok @bytedream now I'm just feeling dumb. The anime name have a ":" and this was the cause of the error.

But it still is a strange behavior, since it downloads all the video and audio tracks and just throw an error when trying to download the subtitle, as show in my screnshot up there.

[valentinegb]

But it still is a strange behavior, since it downloads all the video and audio tracks and just throw an error when trying to download the subtitle, as show in my screnshot up there.

It's probable that it had finished downloading the subtitles and had gone into the FFmpeg phase, which is right after.

[ToMattBan]

Makes sense @valentinegb since the subtitles are what is faster to download (I believe)

[bytedream]

I had sanitation already in place to prevent such errors but it would only sanitize the replaced output template options instead of the full output argument.
The commit above fixes this

[bytedream]

I reverted the commit in v3.2.0. There are simply too many cases where the fix breaks other parts/possibilities (on Windows 🙃), e.g. Windows named pipes, locations on other drives (#289), ...

[ToMattBan]

Yeah man, Windows sucks with this, don't worry too much. Maybe add something on the readme about it?
"The path of the output can't contain any : or /"