Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Failing to generate output file #337

Closed
RBin789 opened this issue Feb 22, 2024 · 4 comments
Closed

Failing to generate output file #337

RBin789 opened this issue Feb 22, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@RBin789
Copy link

RBin789 commented Feb 22, 2024

Describe the bug
When I try to download the season everything works fine it downloads both videos with there respective audio files and the subtitle file then as soon as it starts "Generating output file" it crashs with :

thread 'tokio-runtime-worker' panicked at D:\a\crunchy-cli\crunchy-cli\crunchy-cli-core\src\utils\download.rs:1199:22:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
:: An error occurred: task 1252 panicked

To Reproduce
Just run the command below

archive -a en-US -a zh-CN -s en-US --ffmpeg-preset h264 --speed-limit 2MB -o "{series_name} - S{season_number}E{episode_number} - {title}.mkv" https://www.crunchyroll.com/series/GZJH3DJ8E/the-daily-life-of-the-immortal-king[S2]

Expected behavior
It should download every episode of The Daily Life of the Immortal King Season 2 with English and Mandarin audio and English Subtitles. with files in the form "The Daily Life of the Immortal King - S02E# - Episode Name"

Client:

  • OS: Windows
  • Version crunchy-cli-v3.2.5

Additional context
Downloading has worked for while but yesterday while downloading (The Daily Life of the Immortal King) my computer shutdown unexpectedly, I think something tried to use Hyper-V-Hypervisor when virtualization was disabled so my computer shutdown anyway after that i went into my BIOS and re enabled virtualization. Now it gives the error i described above when i try to download it again. Is crunchy-cli sensitive to virtualization i don't want to disable it just to use crunchy-cli.

@RBin789 RBin789 added the bug Something isn't working label Feb 22, 2024
bytedream added a commit that referenced this issue Feb 23, 2024
@bytedream
Copy link
Member

Hey thanks for your issue report. crunchy-cli does nothing with virtualization so this shouldn't be a blocker.
The error occurs because crunchy-cli asserts that ffmpeg writes its progress in a specific format to a file but in your case there seems to be some sort of issue with the progress output ffmpeg reports.

A fix for such issues will land in the next release

@RBin789
Copy link
Author

RBin789 commented Feb 24, 2024

Thanks for the response in the meantime is there anything i can do to stop the bug?

@bytedream
Copy link
Member

You can use the pre-built windows binary from here (scroll down and download the crunchy-cli-windows-x86_64 file). It contains the fix

@bytedream
Copy link
Member

The fix is now available in v3.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants