This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
Fix rate limiting cms error #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a error Crunchyroll throws if too many streams are requested in a short time period. The error states
content.get_video_streams_v2.cms_service_errorand after the error occurs no stream can be downloaded or watched, even on the Crunchyroll website, for around 30 minutes (to my observations).Before this PR, all streams got requested and the download only began if every stream were fetched. This could result in hundreds of request in a very short time period (depending on the series which should be downloaded) which then triggers the described error.
With this change, streams are only requested before they're actually required. This resolves the issue and reduces the time the cli needs to start the first download.