This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
Add ffmpeg amd hardware acceleration presets #324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hardware acceleration for AMD via the
--ffmpeg-preset
flag. Unfortunately I'm unable to test if it's working because I do not own an AMD card.I need someone with an AMD card to verify that everything works. Testing the
h264-amd-normal
andh265-amd-normal
feature are the minimum requirements for me to merge the feature (testing other quality levels are still desirable though; also AV1 testing would be great, but I'm okay with it to not be tested as only newer AMD models support it). You can either build thefeature/amd-hwaccel
branch yourself or use a pre-built binary.Until the named tests requirements are met, this feature is blocked.