Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Switch to audio fingerprinting based syncing #393

Merged
merged 13 commits into from
May 1, 2024

Conversation

Frooastside
Copy link
Contributor

@Frooastside Frooastside commented Apr 26, 2024

  • moves --sync-start to --merge sync
  • replaces video based syncing with audio based syncing
  • adds --sync-tolerance and --sync-precision to control audio based fingerprinting
  • fixes bug where a message would always be printed out that syncing failed regardless of the actual outcome (except when it failed for a different reason)
  • remove now unused fn tempdir in os.rs
  • updates readme and help messages to reflect the changes

Requires #392 [Merged]

@Frooastside Frooastside changed the title Switch to audio fingerprinting based syncing [Requires #392] Switch to audio fingerprinting based syncing Apr 28, 2024
Copy link
Member

@bytedream bytedream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@bytedream bytedream merged commit 72c574c into crunchy-labs:master May 1, 2024
5 checks passed
@Frooastside Frooastside deleted the video-syncing branch May 1, 2024 22:40
@TokyoBre
Copy link

TokyoBre commented May 22, 2024

Does the --merge sync works good, still in v. 3.6.5
Cause I´ve noticed you changed the subtitle names from (example: German to de-DE)
is there a way to automatically get the full words back?
cause right now iam using an mkv editor, and to change that manually for every subtitle language takes at least 20 minutes per episode...
Other question about, downloading 2 videos for one episode, if you choose multiple audio-languages (auto downloads 2 videos)
(can i choose to only download one of the videos? | Wasnt successful while searching for that in "readme.txt")
--> does the --merge sync work for those, if iam trying to put the english audio onto the japanese video, if the video is not very different (obviously), cause many times there wasnt actually a different video downloaded (2 times exactly the same one)

I want to have the subtitles to click in the video to be like "German" / "English (US)" and not like "de-DE" / "en-US"
right now iam using that (because of crunchy update Iam using the Nintendo Switch --user-agent) :
-->
crunchy.exe --user-agent "Crunchyroll/1.8.0 Nintendo Switch/12.3.12.0 UE4/4.27" archive -a en-US -a de-DE -a ja-JP --skip-existing

? What do I need to edit to make that work? Pls help Iam wasting my time with "mkv editors"

EDIT:

Okay, finally found the -m audio in another post, but still the question for the subtitle names to be given out in full words ("German" | not "de-DE")

@Frooastside
Copy link
Contributor Author

Frooastside commented May 26, 2024

@TokyoBre

Does the --merge sync works good, still in v. 3.6.5
Cause I´ve noticed you changed the subtitle names from (example: German to de-DE)

The two things aren't really related. --merge sync should work, altough im working on a few improvements. You can try to open an issue on the project for your problem with the subtitles names though.

Other question about, downloading 2 videos for one episode, if you choose multiple audio-languages (auto downloads 2 videos)
(can i choose to only download one of the videos? | Wasnt successful while searching for that in "readme.txt")

sometimes 2 audio tracks differ in length and then the videos that have the same length are downloaded so you can still watch it without audio and video being mismatched. --merge sync tries to fix this by cutting the audios to the same length so you only need one video to experience all audios.

another thing you should not need the fix anymore as the user agent is in upstream now (i think)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants