-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEX-5682: iOS Swift Conversion #11
Conversation
…e input to struct
@cristi-lupu There is probably more cleanup and improvement that can be done, but going to cap off the work here in order to move forward on the project. All previous functionality should be working the same. Would you mind having a look over the Swift code, and provide any feedback on improvements that can be made to the syntax or patterns used? |
let certificateUrl: String? | ||
let base64Certificate: Bool? | ||
|
||
let json: NSDictionary? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason you want to keep the initial dictionary object? Applicable for other models as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there is logic that sends back the input dictionary back to the client, instead of converting to DRMParams, then converting back to NSDictionary, this keeps a reference to the original to simply send back
@cristi-lupu thanks for reviewing the swift code! updated. |
Converts iOS implementation from objc to swift
Jira: VEX-5682
https://jira.tenkasu.net/browse/VEX-5682
Velocity PR: https://github.com/crunchyroll/velocity/pull/1966