Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEX-6030: Further prevent memory crashes #15

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

gabriel-rivero
Copy link

@gabriel-rivero gabriel-rivero commented Nov 17, 2021

This PR is intended to prevent memory crashes when the free memory runs out

Jira: VEX-6030
https://jira.tenkasu.net/browse/VEX-6030

Velocity PR: https://github.com/crunchyroll/velocity/pull/2043

By forcefully calling the garbage collector the memory crashes, specially on lower resolutions (<720p) are gone on devices with 2GB of ram or less and Android 6, also testing 3GB Android 7 with this patch, so far is working as intended

Reviews

Testing instructions

1. Target an android 6 device with 2GB of ram or less
2. Execute yarn start-androidmobile-client
3. Make sure to enable "V2" at "config delta override"
4. Play any episode
5. Skip to the middle then near the end
6. Play the next episode
7. Skip to another part of the video
8. Make sure the video plays normally with no crashes

@jctorresM jctorresM self-requested a review November 17, 2021 18:16
Copy link

@jctorresM jctorresM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor

@gabriel-rivero gabriel-rivero merged commit aa63361 into master Nov 17, 2021
@gabriel-rivero gabriel-rivero deleted the bugfix/VEX-6030-further-prevent-memory-crashes branch November 17, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants