Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for a deps-new template #245

Merged
merged 11 commits into from
Oct 15, 2021
Merged

Added support for a deps-new template #245

merged 11 commits into from
Oct 15, 2021

Conversation

bombaywalla
Copy link
Member

No description provided.

@bombaywalla
Moved lein template files into structured directories.
b1b483d
@bombaywalla
First cut at a template.edn for the deps-new template.
01235ee
@bombaywalla
Update the README and CHANGELOG.
dce3e41
@bombaywalla
Specify that the unadorned ```s are for the shell.
e3eae91
@bombaywalla
Updated README copyright notice to 2021.
66414dd
@bombaywalla
Removed orphan markup.clj file.
4c68e56
@bombaywalla
Restructure files as per Sean Corfield's suggestion.
2d32935 
This is to allow for deployment to clojars and to be able to use both
lein and deps-new templates from that one artifact.

Updated CHANGELOG.
@bombaywalla
Updated instructions on how to use this template with deps-new.
5ef6c5c
@bombaywalla
Updated test instructions in CONTRIBUTING.
78abcbb
@bombaywalla
Use explicit code blocks.
f7a0355
@bombaywalla
Update docs to use git deps for deps-new.
614095b 
Since deps-new does not work with jar files.
Since it uses tools.build, which uses files in directories.
@bombaywalla
Copy link
Member Author

This PR is now ready to review.
I have tested it locally and it generates the same files as the lein template.
Once this is merged to master, I can create the release.
(Because deps-new only works with git deps, the documentation will have to be updated (using the new SHA) after the release.)

Then, someone with the credentials can deploy to clojars.

@bombaywalla bombaywalla marked this pull request as ready for review October 15, 2021 02:41
holyjak
holyjak approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@holyjak holyjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks a lot!

@bombaywalla bombaywalla merged commit fcb2833 into master Oct 15, 2021
@bombaywalla bombaywalla deleted the deps-template branch October 15, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holyjak holyjak holyjak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bombaywalla @holyjak