feat(api): mutation operations

[andrewazores]

Includes:

• feat(api): enable dynamic JFR start #165
• feat(api): enable dynamic JFR stop, delete #176
• feat(api): implement GET /recordings/:id for streaming files #179
• feat(api): enable JFR Snapshot #186

[github-actions]

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

[ebaron]

The writes-enabled property looks fine to me. We just need to make sure users are aware of it through documentation. Since this is only gating new functionality for the agent, I don't think it's overly disruptive from a UX perspective.

[mwangggg]

looks good to me 👍

[andrewazores]

@mwangggg do the latest changes make sense to you?

[andrewazores]

@mwangggg ping

[mwangggg]

Sorry I don't seem to be getting notifications when my username is pinged in comments- I just updated my email notification settings so hopefully I can be faster in the future when replying. Regarding the updates, I ran into an error when I tried to stop the cryostat-agent recording in quarkus-test-agent-1. The recording is updated to a STOPPED status as expected, but I'm not sure what's causing the error (the NoSuchElementException):

The cryostat logs:

i://cryostat:9097/jmxrmi"}}
Sep 19, 2023 3:46:39 AM io.cryostat.core.log.Logger error
SEVERE: HTTP 500: No value present
io.vertx.ext.web.handler.HttpException: Internal Server Error
Caused by: java.util.NoSuchElementException: No value present
	at java.base/java.util.Optional.get(Optional.java:143)
	at io.cryostat.recordings.RecordingTargetHelper.lambda$stopRecording$4(RecordingTargetHelper.java:286)
	at io.cryostat.net.TargetConnectionManager.executeConnectedTask(TargetConnectionManager.java:151)
	at io.cryostat.recordings.RecordingTargetHelper.stopRecording(RecordingTargetHelper.java:267)
	at io.cryostat.recordings.RecordingTargetHelper.stopRecording(RecordingTargetHelper.java:260)
	at io.cryostat.net.web.http.api.v1.TargetRecordingPatchStop.handle(TargetRecordingPatchStop.java:40)
	at io.cryostat.net.web.http.api.v1.TargetRecordingPatchHandler.handleAuthenticated(TargetRecordingPatchHandler.java:105)
	at io.cryostat.net.web.http.AbstractAuthenticatedRequestHandler.handle(AbstractAuthenticatedRequestHandler.java:81)
	at io.cryostat.net.web.http.AbstractAuthenticatedRequestHandler.handle(AbstractAuthenticatedRequestHandler.java:51)
	at io.vertx.ext.web.impl.BlockingHandlerDecorator.lambda$handle$0(BlockingHandlerDecorator.java:48)
	at io.vertx.core.impl.ContextBase.lambda$null$0(ContextBase.java:137)
	at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:264)
	at io.vertx.core.impl.ContextBase.lambda$executeBlocking$1(ContextBase.java:135)
	at io.vertx.core.impl.TaskQueue.run(TaskQueue.java:76)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:833)

[andrewazores]

I'll take a look at that over at https://github.com/cryostatio/cryostat/pull/1608 - that target uses the Agent for Discovery only, with a JMX URL for all actual JFR communications, so the recording stop action isn't going through any Agent code here.

[mwangggg]

looks good to me