Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): optionally support Red Hat Insights agent #249

Merged
merged 8 commits into from
Nov 23, 2023

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Nov 9, 2023

This PR adds support for the https://github.com/RedHatInsights/insights-java-agent to generate a report and send it to Red Hat Insights. This functionality is only enabled when the Cryostat Operator is deployed with the INSIGHTS_ENABLED environment variable set to true, which will never be the case for our upstream builds. This is purely for Red Hat product builds.

To test:

  1. Deploy Operator with Insights enabled: make deploy ENABLE_INSIGHTS=true
  2. Build a sample app with this agent PR
  3. Set logging level to debug
  4. Observe payload being successfully sent to Insights in the logs

Fixes: https://github.com/cryostatio/cryostat/issues/1763

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Nov 9, 2023
@mergify mergify bot added the safe-to-test label Nov 9, 2023
@andrewazores andrewazores added feat New feature or request and removed needs-triage Needs thorough attention from code reviewers labels Nov 13, 2023
@ebaron ebaron marked this pull request as ready for review November 20, 2023 17:14
@ebaron ebaron requested a review from a team as a code owner November 20, 2023 17:14
@ebaron ebaron requested a review from andrewazores November 20, 2023 18:00
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once there is a publicly available runtimes-agent.

@ebaron ebaron merged commit ffcc28d into cryostatio:main Nov 23, 2023
10 checks passed
mergify bot pushed a commit that referenced this pull request Nov 23, 2023
* feat(registration): receive platform env map from server on registration

* feat(insights): support Red Hat Insights agent

Signed-off-by: Elliott Baron <ebaron@redhat.com>

* Update for Insights proxy

* Suppress FindBugs warning

* Add unit tests

* Use released Insights Agent, update for shading

---------

Signed-off-by: Elliott Baron <ebaron@redhat.com>
Co-authored-by: Andrew Azores <aazores@redhat.com>
(cherry picked from commit ffcc28d)
ebaron added a commit that referenced this pull request Nov 23, 2023
* feat(registration): receive platform env map from server on registration

* feat(insights): support Red Hat Insights agent

Signed-off-by: Elliott Baron <ebaron@redhat.com>

* Update for Insights proxy

* Suppress FindBugs warning

* Add unit tests

* Use released Insights Agent, update for shading

---------

Signed-off-by: Elliott Baron <ebaron@redhat.com>
Co-authored-by: Andrew Azores <aazores@redhat.com>
(cherry picked from commit ffcc28d)

Co-authored-by: Elliott Baron <ebaron@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport feat New feature or request safe-to-test
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Story] Integration with Red Hat Insights for Red Hat customers
2 participants