-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(insights): optionally support Red Hat Insights agent #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliott Baron <ebaron@redhat.com>
github-actions
bot
added
the
needs-triage
Needs thorough attention from code reviewers
label
Nov 9, 2023
andrewazores
added
feat
New feature or request
and removed
needs-triage
Needs thorough attention from code reviewers
labels
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, once there is a publicly available runtimes-agent
.
andrewazores
approved these changes
Nov 23, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
* feat(registration): receive platform env map from server on registration * feat(insights): support Red Hat Insights agent Signed-off-by: Elliott Baron <ebaron@redhat.com> * Update for Insights proxy * Suppress FindBugs warning * Add unit tests * Use released Insights Agent, update for shading --------- Signed-off-by: Elliott Baron <ebaron@redhat.com> Co-authored-by: Andrew Azores <aazores@redhat.com> (cherry picked from commit ffcc28d)
ebaron
added a commit
that referenced
this pull request
Nov 23, 2023
* feat(registration): receive platform env map from server on registration * feat(insights): support Red Hat Insights agent Signed-off-by: Elliott Baron <ebaron@redhat.com> * Update for Insights proxy * Suppress FindBugs warning * Add unit tests * Use released Insights Agent, update for shading --------- Signed-off-by: Elliott Baron <ebaron@redhat.com> Co-authored-by: Andrew Azores <aazores@redhat.com> (cherry picked from commit ffcc28d) Co-authored-by: Elliott Baron <ebaron@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the https://github.com/RedHatInsights/insights-java-agent to generate a report and send it to Red Hat Insights. This functionality is only enabled when the Cryostat Operator is deployed with the
INSIGHTS_ENABLED
environment variable set to true, which will never be the case for our upstream builds. This is purely for Red Hat product builds.To test:
make deploy ENABLE_INSIGHTS=true
Fixes: https://github.com/cryostatio/cryostat/issues/1763