-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CI): Build container image #397
Conversation
136e73f
to
d40e74b
Compare
69718ed
to
7e374bc
Compare
Looking good. Could you get this to run in your fork to validate that we haven't missed anything among the recent changes? Obviously the quay.io piece won't work, unless you also set up your fork with the token secret. |
I finally got a workflow that works- I completely forgot that there's no easy way to get the PR associated with a push event, so I had to remove the the safe-to-test label checking and commenting the quay image after it's been successfully pushed: https://github.com/mwangggg/cryostat-agent/actions/runs/9813147572 |
Ahh, yes, that makes sense. I think it's fine to just have it work on push, I don't think there will be that many PRs going on in this repo. https://quay.io/repository/redhat-java-monitoring/quarkus-cryostat-agent?tab=tags Workflow results look good. I think it makes sense to tag this container image with the Agent version (as your workflow did) rather than the application's own version, too. |
b17a086
to
d4d29c4
Compare
related to: cryostatio/cryostat-operator#791
This CI workflow builds the agent image, then packages it in the quarkus-test sample application and pushes it to the crysotat quay repo.
example workflow in my forked -agent repo: https://github.com/mwangggg/cryostat-agent/actions/runs/8974812712