Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split implementations from interfaces and simple models #416

Closed
andrewazores opened this issue Jul 2, 2024 · 0 comments · Fixed by #423
Closed

Split implementations from interfaces and simple models #416

andrewazores opened this issue Jul 2, 2024 · 0 comments · Fixed by #423
Assignees
Labels
chore Refactor, rename, cleanup, etc.

Comments

@andrewazores
Copy link
Member

Most of the Cryostat project is happily using JDK 17 and will upgrade to JDK 21 when other dependencies upgrade. However, the Cryostat Agent will always want to lag behind this and remain compatible with a wider range of JDK versions. At the moment this means supporting JDK 11 as well. However, the JMC dependencies (#173) used here in -core now require JDK17+.

We should split this library up into parts that are JDK17+ or JDK21+, including all of the JMC-related pieces, and a part that is JDK-11 compatible including the few small pieces that are used by the Agent. This split off library could be called something like cryostat-interfaces or cryostat-models, and would contain only things like interface definitions or simple classes used for serialization. Then the Agent would only use this new dependency, and the other containers/components can use -core and upgrade freely to newer JDK versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant