Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(libcryostat): clean up to use libcryostat dependency #441

Merged
merged 3 commits into from
Jul 19, 2024
Merged

chore(libcryostat): clean up to use libcryostat dependency #441

merged 3 commits into from
Jul 19, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test labels Jul 18, 2024
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Jul 18, 2024
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Jul 18, 2024
@andrewazores andrewazores marked this pull request as ready for review July 18, 2024 21:05
@andrewazores andrewazores requested a review from a team as a code owner July 18, 2024 21:05
ebaron
ebaron reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this still need libcryostat from Maven Central's snapshots repo?

@ebaron
Copy link
Member

ebaron commented Jul 19, 2024

Won't this still need libcryostat from Maven Central's snapshots repo?

Wow nevermind, I thought the addition was a removal

@andrewazores andrewazores merged commit 2b5cb20 into cryostatio:main Jul 19, 2024
9 checks passed
@andrewazores andrewazores deleted the libcryostat branch July 19, 2024 20:57
@andrewazores andrewazores mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @ebaron