-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): test -core's build in Cryostat image #275
Conversation
The integration tests are currently failing, but I'm not sure if it's because the -core version is incompatible or because of something else: https://github.com/mwangggg/cryostat-core/actions/runs/6537266768 |
Can you try to trigger that CI run again and see if it fails the same way? |
Okay, that's a very different integration test failure. The first looks like it could have been a cascade of failures after something broke with target discovery during the test. The second looks like https://github.com/cryostatio/cryostat/issues/1661 or something very similar. |
hmm seems like the first run I commented was a rare occasion |
just so I don't forget- Thuan and I were discussing adding the ability to checkout a related PR in Cryostat to test both PRs in Cryostat and -core at the same time. |
fae253c
to
8314849
Compare
I can't believe I spent all this time trying to figure out why the integration tests were failing, only to realize it was because I accidentally ran the tests with the arm64 image instead of the amd64 image. Successful run: https://github.com/mwangggg/cryostat-core/actions/runs/6578935994/job/17873725369 |
638f787
to
63e54ee
Compare
fixes: #221
(accidentally closed previous PR: #266)