Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): test -core's build in Cryostat image #275

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Oct 16, 2023

fixes: #221
(accidentally closed previous PR: #266)

@mwangggg mwangggg added ci feat New feature or request safe-to-test labels Oct 16, 2023
@mwangggg
Copy link
Member Author

The integration tests are currently failing, but I'm not sure if it's because the -core version is incompatible or because of something else: https://github.com/mwangggg/cryostat-core/actions/runs/6537266768

@andrewazores
Copy link
Member

Can you try to trigger that CI run again and see if it fails the same way?

@mwangggg
Copy link
Member Author

@andrewazores
Copy link
Member

Okay, that's a very different integration test failure. The first looks like it could have been a cascade of failures after something broke with target discovery during the test. The second looks like https://github.com/cryostatio/cryostat/issues/1661 or something very similar.

@mwangggg
Copy link
Member Author

mwangggg commented Oct 16, 2023

hmm seems like the first run I commented was a rare occasion

@mwangggg
Copy link
Member Author

just so I don't forget- Thuan and I were discussing adding the ability to checkout a related PR in Cryostat to test both PRs in Cryostat and -core at the same time.

@mwangggg
Copy link
Member Author

I can't believe I spent all this time trying to figure out why the integration tests were failing, only to realize it was because I accidentally ran the tests with the arm64 image instead of the amd64 image. Successful run: https://github.com/mwangggg/cryostat-core/actions/runs/6578935994/job/17873725369

@andrewazores andrewazores merged commit 17a29a3 into cryostatio:main Oct 19, 2023
5 checks passed
@mwangggg mwangggg deleted the 221-cryostat-IT branch March 12, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] PR CI should test -core changes in a Cryostat container image against existing itests
3 participants