fix(reports): split rule evaluations across executor submissions #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
parallel-analysis
branch
from
0f38223 to
a565e6e
Compare
andrewazores
force-pushed
the
parallel-analysis
branch
from
a565e6e to
400f257
Compare
To run smoketest: |
|
/build_test |
|
Cryostat Test: At least one test failed ❌ |
|
/build_test |
|
Cryostat Test: At least one test failed ❌ |
|
Cryostat Test: All tests pass ✅ |
andrewazores
force-pushed
the
parallel-analysis
branch
from
400f257 to
868f248
Compare
|
/build_test |
|
Cryostat Test: At least one test failed ❌ |
|
Image does not exist! Please wait for the initial build and push to complete before using |
7 tasks
andrewazores
force-pushed
the
parallel-analysis
branch
2 times, most recently
from
062bd79 to
2f8c90c
Compare
andrewazores
force-pushed
the
parallel-analysis
branch
from
2f8c90c to
6a6aaf3
Compare
To run smoketest: |
To run smoketest: |
aali309
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuleEvaluatorcauses the whole queue of futures to be evaluated by whoever callsevaluator.run()- in this case, one thread from the Executor. If there are many threads available via that Executor then we don't take any advantage of the parallelism possible in analysis rules this way. With this PR thisRuleEvaluatoris removed and each rule in the queue to be processed is immediately submitted to the executor pool, then the final results are all collected by theqThreadand returned. This way a multithreaded executor provides more parallelism within individual rule analyses, rather than only helping to parallelize multiple analyses - ie parallelism within a single file analysis instead of only at the per-file level.