chore(jmc-core): update to JMC version 9.0.0

[aptmac]

Fixes #365

This PR goes against issues #22 and #173, in which it would be nice to not have to embed JMC sources into cryostat-core.

As of JMC 9.0.0, the requisite classes for cryostat-core to run have been moved into the JMC core libraries. This includes changes in existing packages, and the newly moved flightrecorder.configuration and rjmx.common packages.

At the moment, JMC 9 core libraries are available for download on the Adoptium repositories, and that's what this PR makes use of. If it'd be preferable to wait and use Maven Central supplied artifacts instead, I can just draft this PR and update it when they're released.

[andrewazores]

Love it.

[andrewazores]

At the moment, JMC 9 core libraries are available for download on the Adoptium repositories, and that's what this PR makes use of. If it'd be preferable to wait and use Maven Central supplied artifacts instead, I can just draft this PR and update it when they're released.

#337 - I would prefer to wait a while for Maven Central publication, just to keep things a little tidier.

[andrewazores]

Looks like it must be on Central now, since Dependabot picked it up over here first: cryostatio/jfr-datasource#284

[aptmac]

Looks like it must be on Central now, since Dependabot picked it up over here first: cryostatio/jfr-datasource#284

Excellent, yeah I can see the updated versions at: https://central.sonatype.com/artifact/org.openjdk.jmc/common/versions

It doesn't look like flightrecorder.configuration or rjmx.common have made it yet though, so I'll wait for them to show up and then re-visit this PR.

[aptmac]

Looks like it must be on Central now, since Dependabot picked it up over here first: cryostatio/jfr-datasource#284

Excellent, yeah I can see the updated versions at: https://central.sonatype.com/artifact/org.openjdk.jmc/common/versions

It doesn't look like flightrecorder.configuration or rjmx.common have made it yet though, so I'll wait for them to show up and then re-visit this PR.

I've opened https://bugs.openjdk.org/browse/JMC-8217 to track the inclusion of the missing core artifacts into Maven Central. Oracle opted to simply update the existing artifacts for 9.0.0 without adding the new ones.

When asked about it, the timeline went from 9.1.0 (2025-01-29), to a 9.0.X release (which might be on the horizon to fix a PID formatting issue), to a "we'll try to add them soon" in response to the above jira ticket.

[aptmac]

I've rebased here, locally it's looking good with mvn verify across cryostat-reports, cryostat, and cryostat3.

What do you think is the best way to go about reviewing this work? The cryostat3 CI step isn't going to be too happy because core and reports will need the changes first. If you want to try it locally, I've prepared my later branches to use 2.31.0-SNAPSHOT so that you could locally build and test across cryostat-core -> cryostat-reports -> cryostat3, and then we could circle back once that's been verified.

See:

• https://github.com/aptmac/cryostat-reports/tree/jmc9
• https://github.com/aptmac/cryostat/tree/jmc9
• https://github.com/aptmac/cryostat3/tree/jmc9

[andrewazores]

The cryostat3 CI step isn't going to be too happy because core and reports will need the changes first.

Yep, that's fine. That step is there to help catch accidental breakages, but when they're expected then I'm fine with ignoring it and validating things manually.

[andrewazores]

https://github.com/aptmac/cryostat3/tree/jmc9

404 here

[aptmac]

https://github.com/aptmac/cryostat3/tree/jmc9

404 here

Ah I still had the repo set to private, it should be visible now.

[andrewazores]

Conflicting files
src/main/java/io/cryostat/core/templates/LocalStorageTemplateService.java

This file has been removed, so it's a trivial merge/rebase fix.

[andrewazores]

Manual reviews are all looking good. The Agent also consumes this dependency but doesn't actually use any of the JMC pieces, so it shouldn't need any additional work.