Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(modules): build and publish modules separately #426

Merged
merged 5 commits into from
Jul 19, 2024
Merged

ci(modules): build and publish modules separately #426

merged 5 commits into from
Jul 19, 2024

Conversation

andrewazores
Copy link
Member

  • build(mvn): copy mvnw to modules
  • ci(release): copy jreleaser scripts to modules
  • ci(push): check out with fetch-depth 0
  • ci(modules): build and publish modules separately

Fixes #425

@andrewazores andrewazores requested a review from ebaron July 19, 2024 13:27
@andrewazores andrewazores requested review from aali309 and mwangggg July 19, 2024 15:56
@andrewazores andrewazores merged commit 7439c76 into cryostatio:main Jul 19, 2024
10 checks passed
@andrewazores andrewazores deleted the ci-separate-module-builds branch July 19, 2024 21:08
This was referenced Jul 19, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-426-6ca1589bdeb446e004c289fc44803e0972893f07-linux-java17

To run smoketest:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-426-6ca1589bdeb446e004c289fc44803e0972893f07-linux-java17 bash smoketest.bash

@andrewazores
Copy link
Member Author

This didn't work as intended, rolling it back and will reconsider the approach.

andrewazores added a commit to andrewazores/cryostat-core that referenced this pull request Jul 19, 2024
@andrewazores
Revert "ci(modules): build and publish modules separately (cryostatio…
9c10058 
…#426)"

This reverts commit 7439c76.
@andrewazores andrewazores mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@aali309 aali309 Awaiting requested review from aali309

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
ci safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] libcryostat should not only target JDK 11, but should be built with JDK 11
2 participants
@andrewazores @ebaron