chore(jmc-core): Upgrade Java Mission Control to version 8.1.0

[oscerd]

Fixes #95

Pointing JMC 8.1.0

[oscerd]

cc @andrewazores

[andrewazores]

This will take some more attention to review. I will need to test the main Cryostat project with this upgraded version and ensure everything still works as expected after the major JMC version bump.

[aptmac]

Just a heads up on this, JfrHtmlRulesReport (used to generate the automated analysis in ReportGenerator) is broken as of JMC 8; I would give this a test to make sure the automated analysis pages can be generated.

The upstream issue can be tracked at: https://bugs.openjdk.java.net/browse/JMC-7231 [0]

There is currently a fix under review [1], but currently requires a bit more work. A fix will hopefully be incorporated in 8.2.0.

[0] https://bugs.openjdk.java.net/browse/JMC-7231
[1] openjdk/jmc#302

[oscerd]

Do you need any help on this?

[andrewazores]

I haven't had a chance to test this, although now that I'm here thinking about this again I think upgrading the JMC version will take a little more work. For downstream build purposes we have some portions of JMC forked and embedded directly into our -core here ( https://github.com/cryostatio/cryostat-core/tree/main/src/main/java/org/openjdk/jmc ). So, not only does the pom need to be updated for the new JMC version, but these embedded sources need to be either removed or updated as well. @ebaron - what's your take?

[ebaron]

There's some work happening upstream in JMC to move remote JMX utilities to JMC Core: https://bugs.openjdk.java.net/browse/JMC-7069. The embedded sources in this project are a temporary measure to avoid pulling in Eclipse dependencies until this refactoring is done and we no longer need to depend on the JMC Application code.

Updating the embedded JMC application sources in this project is a time consuming and error prone process, but it may be worth doing. I expect that we would want to keep both the JMC core dependency and embedded JMC application sources at the same version.

[jiekang]

@oscerd Hi! As @aptmac mentioned there is a critical bug in 8.1.0 core that affects our use of the automated analysis API. I think upstream JMC is releasing 8.1.1 very soon to address that. I'll keep an eye on that; when the release is made, I think we should update to 8.1.1 instead.

[oscerd]

@jiekang sure, I'll update once it will be available.

[oscerd]

8.2.0 is out. Is it a target for Cryostat-core?

[andrewazores]

@oscerd yes, we just had our planning meeting for the next Cryostat release and updating cryostat-core for JMC 8.1.1 or 8.2.0 is a higher priority item on the list. It does not seem that the JMC refactoring to extract all of the parts we use into jmc-core is done yet, so there is still a need to manually update the embedded fork within cryostat-core as well.

[andrewazores]

Superseded by #201